On Thu, Sep 19, 2019 at 4:24 PM Dave Page <dpage@pgadmin.org> wrote:
If we can do it automatically at startup based on whether or not the Python code thinks we're running under Desktop mode or not, then I suppose it's a win. That would replace one test per request with one test at startup. It'll still be a minute difference, but every little bit helps I guess.
Does this work with both X-Scheme and X-Forwarded-Proto headers as discussed?
The proxy fix work for all standard X-Forwarded-* headers. X-Scheme is not used anywhere, X-Forwarded-Proto is more robust.
Right, but our existing code uses X-Scheme (as per old advice since removed from the Flask website - see RM3149), and users have deployments that will be setup that way. We need to fall back to X-Scheme if it is present but X-Forwarded-Proto is not, to avoid breaking their installations.
I assume (as you haven't removed it) that it works in conjunction with the existing reverse proxy code?
