Postgres Pro
Downloads
Home   >   mailing lists

Re: Reordering DISTINCT keys to match input path's pathkeys - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Reordering DISTINCT keys to match input path's pathkeys
Date
Msg-id CAMbWs4-umfOaTKtppL7mw0X312+bw5g8etJBQLLQ1MSuK1hr-w@mail.gmail.com
Whole thread Raw
In response to Re: Reordering DISTINCT keys to match input path's pathkeys  (Andrei Lepikhov <lepihov@gmail.com>)
Responses Re: Reordering DISTINCT keys to match input path's pathkeys
Re: Reordering DISTINCT keys to match input path's pathkeys
List pgsql-hackers
Tree view 
On Fri, Nov 22, 2024 at 5:40 PM Andrei Lepikhov <lepihov@gmail.com> wrote:
> I wonder if it would be possible to print only three rows instead of 10
> to prove the DISTINCT's correctness.

There are ten distinct values in the 'distinct_tbl' test table, so
I think it’d better to print all of them to verify correctness.

> Also, to stabilise tests with parallel workers, I would recommend
> setting max_parallel_workers_per_gather into 1 and enabling
> debug_parallel_query.

Since we're testing sort-based DISTINCT, the results will always be
well-ordered, so they should be pretty stable as is.

I've applied some of the changes you suggested in your previous email
and pushed the updated patch.  Thank you for your review.

Thanks
Richard

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Self contradictory examining on rel's baserestrictinfo
Next
From: Richard Guo
Date:
Subject: Re: Some dead code in get_param_path_clause_serials()