pg_dump warnings in MinGW build - Mailing list pgsql-hackers

From Jeff Janes
Subject pg_dump warnings in MinGW build
Date
Msg-id CAMkU=1ze2hMZ61LOfifAbiDdRiNKOA963Ao_e8+n7dQuUz2U7A@mail.gmail.com
Whole thread Raw
Responses Re: pg_dump warnings in MinGW build
List pgsql-hackers
Now that popen and pclose don't throw thousands of warnings when compiling mingw builds, some other warnings stand out.


parallel.c: In function 'pgpipe':
parallel.c:1332:2: warning: overflow in implicit constant conversion [-Woverflow]
parallel.c:1386:3: warning: overflow in implicit constant conversion [-Woverflow]

I think the solution is to use the pgsocket typedef from src/include/port.h, rather than int.  Like attached.

But I'm far from being a typedef lawyer, so maybe I am all wet.

Cheers,

Jeff
Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: wrapping in extended mode doesn't work well with default pager
Next
From: Bruce Momjian
Date:
Subject: Re: Proposal for CSN based snapshots