Re: [PATCH] LockAcquireExtended improvement - Mailing list pgsql-hackers

From Will Mortensen
Subject Re: [PATCH] LockAcquireExtended improvement
Date
Msg-id CAMpnoC5f+eiS7tdy8PUpd_LacSTVT-pYpVooKfjHRQQmkHPZ2g@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] LockAcquireExtended improvement  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [PATCH] LockAcquireExtended improvement
List pgsql-hackers
On Thu, Mar 14, 2024 at 1:15 PM Robert Haas <robertmhaas@gmail.com> wrote:
> Seeing no further discussion, I have committed my version of this
> patch, with your test case.

This comment on ProcSleep() seems to have the values of dontWait
backward (double negatives are tricky):

    * Result: PROC_WAIT_STATUS_OK if we acquired the lock,
PROC_WAIT_STATUS_ERROR
    * if not (if dontWait = true, this is a deadlock; if dontWait = false, we
    * would have had to wait).

Also there's a minor typo in a comment in LockAcquireExtended():

    * Check the proclock entry status. If dontWait = true, this is an
    * expected case; otherwise, it will open happen if something in the
    * ipc communication doesn't work correctly.

"open" should be "only".



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Add new error_action COPY ON_ERROR "log"
Next
From: Nathan Bossart
Date:
Subject: Re: recovery modules