Re: PATCH: psql tab completion for SELECT - Mailing list pgsql-hackers

From Edmund Horner
Subject Re: PATCH: psql tab completion for SELECT
Date
Msg-id CAMyN-kCr6aUFaE=ov+_r=b4nS_ihtmJ8-MLMoomZGWdNFgMaVw@mail.gmail.com
Whole thread Raw
In response to [HACKERS] PATCH: psql tab completion for SELECT  (Edmund Horner <ejrh00@gmail.com>)
Responses Re: PATCH: psql tab completion for SELECT
List pgsql-hackers
And here's a patch to add savepoint protection for tab completion.

It could definitely use some scrutiny to make sure it's not messing up
the user's transaction.

I added some error checking for the savepoint creation and the
rollback, and then wrapped it in #ifdef NOT_USED (just as the query
error checking is) as I wasn't sure how useful it is for normal use.

But I do feel that if psql unexpectedly messes up the transaction, it
should report it somehow.  How can we tell that we've messed it up for
the user?

Cheers,
Edmund

Attachment

pgsql-hackers by date:

Previous
From: Joe Wildish
Date:
Subject: Re: Implementing SQL ASSERTION
Next
From: Andres Freund
Date:
Subject: Re: PATCH: psql tab completion for SELECT