Hi,
On Tue, 9 Dec 2025 at 13:23, VASUKI M <vasukim1992002@gmail.com> wrote:
>
> Thanks Michael and Peter for the detailed reviews and for taking the time to refine and commit the updated version.
>
> Thanks for pointing out that pgperltidy may behave differently across environments.
>
> On Tue, 9 Dec 2025 at 11:56, Michael Paquier <michael@paquier.xyz> wrote:
>>
>> The attached takes care of the issue here. Adding that to pgxs_bins
>> may look adapted at first glance, but I don't quite see the point in
>> exposing this information to PGXS, so pgxs_empty is a better fit?
>>
> Thanks for the clarification.Given that PGXS extensions don't appear to require NM ,IMO adding it to pgxs_empty makes
senseto me.It resolves the Meson warning without exposing unnecessary variables to PGXS users.
I agree with both of you. We do the same thing for 'ZIC' binary, so I
think putting it to pgxs_empty is the correct fix.
--
Regards,
Nazir Bilal Yavuz
Microsoft
