Hi,
On Fri, 31 Oct 2025 at 15:13, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
>
> On Wed, 13 Aug 2025 at 16:25, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
> >
> > Hi,
> >
> > On Mon, 7 Jul 2025 at 11:45, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
> > >
> > > Mandatory rebase, v6 is attached.
> >
> > Rebase is needed due to 01d6832c10, v7 is attached.
>
> Rebase is needed due to 16607718c0, v8 is attached.
Rebase is needed. Also, there is small functional change in 0002:
def remove_duplicates(duplicate_str):
- words = duplicate_str.split()
+ # Remove duplicates based on basename as there could be a mix of both full
+ # paths and bare binary names.
+ words = [os.path.basename(word) for word in duplicate_str.split()]
return ' '.join(sorted(set(words), key=words.index))
It is because MacOS was failing due to there being 2 instances of
ccache, one is with full path '/opt/local/bin/ccache' and one is just
the binary name 'ccache'. remove_duplicates() function did not remove
them as it compared full strings before, now it compares only
basenames.
--
Regards,
Nazir Bilal Yavuz
Microsoft
