Re: Excessive PostmasterIsAlive calls slow down WAL redo - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Excessive PostmasterIsAlive calls slow down WAL redo
Date
Msg-id CANP8+j+s2qvXu5xNbmCPXWuK8d_jkT7NHPUsj6CAV_JoUWgEaw@mail.gmail.com
Whole thread Raw
In response to Excessive PostmasterIsAlive calls slow down WAL redo  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
On 5 April 2018 at 08:23, Heikki Linnakangas <hlinnaka@iki.fi> wrote:

> That seems like an utter waste of time. I'm almost inclined to call that a
> performance bug. As a straightforward fix, I'd suggest that we call
> HandleStartupProcInterrupts() in the WAL redo loop, not on every record, but
> only e.g. every 32 records. That would make the main redo loop less
> responsive to shutdown, SIGHUP, or postmaster death, but that seems OK.
> There are also calls to HandleStartupProcInterrupts() in the various other
> loops, that wait for new WAL to arrive or recovery delay, so this would only
> affect the case where we're actively replaying records.

+1

-- 
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: typcategory for regconfig
Next
From: David Rowley
Date:
Subject: Re: Get the name of the target Relation from Query struct?