Re: [PATCH] explain sortorder - Mailing list pgsql-hackers

From Mike Blackwell
Subject Re: [PATCH] explain sortorder
Date
Msg-id CANPAkgsKtPxLGF_Xx_p20B-5gb98BvCYqy9FrjzLD6RTbdPD8g@mail.gmail.com
Whole thread Raw
In response to [PATCH] explain sortorder  ("Timmer, Marius" <marius.timmer@uni-muenster.de>)
Responses Re: [PATCH] explain sortorder
Re: [PATCH] explain sortorder
List pgsql-hackers
Initial review:

Patch applies cleanly to current head, although it appears to have soft/hard tab and trailing space issues.

make check fails with the output below.  The expected collation clause is not present.

--
-- Test explain feature: sort order
--
CREATE TABLE sortordertest (n1 char(1), n2 int4);
-- Insert values by which should be ordered
INSERT INTO sortordertest(n1, n2) VALUES ('d', 5), ('b', 3), ('a', 1), ('e', 2), ('c', 4);
-- Display sort order when explain analyze and verbose are true.
EXPLAIN (VERBOSE, COSTS OFF) SELECT * FROM sortordertest ORDER BY n1 COLLATE "C" DESC, n2;
                   QUERY PLAN                   
------------------------------------------------
 Sort
   Output: n1, n2, ((n1)::character(1))
   Sort Key: sortordertest.n1, sortordertest.n2
   Sort Order:  ASC NULLS LAST,  ASC NULLS LAST
   ->  Seq Scan on public.sortordertest
         Output: n1, n2, n1
(6 rows)

DROP TABLE sortordertest;


__________________________________________________________________________________
Mike Blackwell | Technical Analyst, Distribution Services/Rollout Management | RR Donnelley
1750 Wallace Ave | St Charles, IL 60174-3401
Office: 630.313.7818
Mike.Blackwell@rrd.com
http://www.rrdonnelley.com

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Commit fest 2014-12, let's begin!
Next
From: Andres Freund
Date:
Subject: Re: Something is broken in logical decoding with CLOBBER_CACHE_ALWAYS