Re: [PATCH} Move instrumentation structs - Mailing list pgsql-hackers

On Tue, Jan 13, 2026 at 6:38 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2026-Jan-13, David Rowley wrote:
>
> > There's a bit of conflicting opinion going on here with the changes
> > made in 128897b101e0.

> Sounds about right, though I think we can shave some words off that.
> How about
>
>     int64       maxSpace;       /* maximum amount of space occupied among sort
>                                  * of groups, either in-memory or on-disk */
>     bool        isMaxSpaceDisk; /* true when maxSpace tracks on-disk space, false
>                                  * means in-memory */
> ?
>
> (CCed Jacob as author and John as committer of that change, in case they
> care to comment.)

Hmm, yeah, that commit wasn't quite enough to make that phrase clear,
but I don't remember the interpretation.

--
John Naylor
Amazon Web Services