Re: vacuumdb changes for stats import/export - Mailing list pgsql-hackers

From John Naylor
Subject Re: vacuumdb changes for stats import/export
Date
Msg-id CANWCAZb59knm4GijAuwxdfOSPfbxdpX2kEh9WEao05zQGAQsLA@mail.gmail.com
Whole thread Raw
In response to Re: vacuumdb changes for stats import/export  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: vacuumdb changes for stats import/export
List pgsql-hackers
On Sat, Mar 1, 2025 at 3:42 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Thu, Feb 27, 2025 at 04:36:04PM +0700, John Naylor wrote:

> > I had to read it several times before I noticed the difference between
> > "* found_objs" and "*found_objs". Maybe some extra spacing and breaks
> > would help, or other reorganization.
>
> Yeah, it's pretty atrocious.  I think the main problem is that the
> interface is just too complicated, so I'll take a step back and see if I
> can make it more understandable to humans.

The interface is awkward, but on the other hand only a small part has
to really know about it. It's worth trying to make it more readable if
you can.

> In the meantime, here's an
> attempt at adjusting the comment:

That's better, and if we end up with this interface, we'll want quotes
around the names so the eye can tell where the "*" belong.

--
John Naylor
Amazon Web Services



pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: SIMD optimization for list_sort
Next
From: Andrei Lepikhov
Date:
Subject: Re: Considering fractional paths in Append node