Re: GiST README typos - Mailing list pgsql-hackers

From John Naylor
Subject Re: GiST README typos
Date
Msg-id CANWCAZbiVYq+2cR0swO45czKXv8-cLch-51mSSrtBcFy88U80w@mail.gmail.com
Whole thread Raw
In response to Re: GiST README typos  (Paul A Jungwirth <pj@illuminatedcomputing.com>)
List pgsql-hackers
On Thu, Nov 6, 2025 at 1:36 PM Paul A Jungwirth
<pj@illuminatedcomputing.com> wrote:
>
> On Wed, Nov 5, 2025 at 7:00 PM John Naylor <johncnaylorls@gmail.com> wrote:
> >
> >  being empty. Whenever we find one, we acquire a lock on the parent and child
> > -page, re-check that the child page is still empty. Then, we remove the
> > +page, then re-check that the child page is still empty. Then, we remove the
> >  downlink and mark the child as deleted, and release the locks.
> >
> > I still find this a bit awkward -- perhaps "and re-check"? The last
> > sentence could do with just the last "and" as well, I think, but
> > that's a style consideration and not a grammar fix.
>
> I nearly wrote it that way myself. It's nice that it avoids the double
> "then". So I agree, let's go with "and re-check".

Pushed that way, thanks!

--
John Naylor
Amazon Web Services



pgsql-hackers by date:

Previous
From: Andreas Karlsson
Date:
Subject: Re: ago(interval) → timestamptz
Next
From: Heikki Linnakangas
Date:
Subject: Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue