Postgres Pro
Downloads
Home   >   mailing lists

Re: [WIP PATCH] Index scan offset optimisation using visibility map - Mailing list pgsql-hackers

From Michail Nikolaev
Subject Re: [WIP PATCH] Index scan offset optimisation using visibility map
Date
Msg-id CANtu0ohBE_JmQ43YuPiPBrkasgwF6M3rGzsY91g2UiGtosm9Hw@mail.gmail.com
Whole thread Raw
In response to Re: [WIP PATCH] Index scan offset optimisation using visibility map  (Andrey Borodin <x4mmm@yandex-team.ru>)
Responses Re: [WIP PATCH] Index scan offset optimisation using visibility map
List pgsql-hackers
Tree view
Hello.

> Sorry, seems like I've incorrectly expressed what I wanted to say.
> I mean this Assert() can be checked before loop, not on every loop cycle.

Yes, I understood it. Condition should be checked every cycle - at least it is done this way for index only scan:  https://github.com/postgres/postgres/blob/master/src/backend/executor/nodeIndexonlyscan.c#L234

But since original index scan do not contains such check (probably due ot https://github.com/postgres/postgres/blob/master/src/backend/executor/nodeIndexscan.c#L552) - I think it could be removed.

Michail.

pgsql-hackers by date:

Previous
From: Konstantin Knizhnik
Date:
Subject: Re: All Taxi Services need Index Clustered Heap Append
Next
From: Ildar Musin
Date:
Subject: Re: Failed to request an autovacuum work-item in silence