Re: Quick search for menu items & help articles - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: Quick search for menu items & help articles
Date
Msg-id CANxoLDeQtkJjtpG_c8N1t=OS1y3cgPif+X7sLmwg_mq62au1uw@mail.gmail.com
Whole thread Raw
In response to Quick search for menu items & help articles  (Pramod Ahire <pramod.ahire@enterprisedb.com>)
Responses Re: Quick search for menu items & help articles
List pgadmin-hackers
Hi Pramod

Following are the review comments:
  • linter issue "Undefined variable $black"
  • In Desktop mode remove the separator beside the search icon.

On Thu, Jan 14, 2021 at 10:18 PM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:

Hi Team, 

 

Please find the attached designs & patch that contains complete functionality except below to do for quick search.

 

To Do: 

 

  • Unit test cases are not that sufficient to cover complete code, but will be working in background to cover up those one
  • In pgadmin, for disabled menu items we need to add info that will describe why menu has disabled & how it will be enabled. Either another way to enable all of them & show respective reason in popup that menu is disabled for. 

 

Please do let me know if I missed anything or suggestion of yours.

 

Thanks !

 

Pramod Ahire

Software Engineer

 

https://lh4.googleusercontent.com/U1erEuyI_d0xEUA0CrKjwx9aWQ52HNCxc38dMsLP-ZrLgfVNrhsrNobxlmeOdb1kMPtrrxcUwEHZgbGJC4R0qR4r1sBZa_z9R8ihFRaP2Hr_Wnhq6HcIQHe1ZoviDPwUkTdzNcg

 

C: +91-020-66449600/601

D: +91-9028697679

edbpostgres.com

 



--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Attachment

pgadmin-hackers by date:

Previous
From: Nikhil Mohite
Date:
Subject: [pgAdmin][RM-6122]: There is no informative message when there is no diff found
Next
From: Pramod Ahire
Date:
Subject: Re: Quick search for menu items & help articles