Re: Lazy allocation of pages required for verifying FPI consistency - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Lazy allocation of pages required for verifying FPI consistency
Date
Msg-id CAOBaU_aoCdobmRPtxTFNUF8zeNOvyrwWkL4E=yhofgpY2eEZSQ@mail.gmail.com
Whole thread Raw
In response to Re: Lazy allocation of pages required for verifying FPI consistency  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: Lazy allocation of pages required for verifying FPI consistency
List pgsql-hackers
On Thu, Jan 12, 2023 at 4:29 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
>
> At Mon, 9 Jan 2023 20:00:00 +0530, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote in
> > I propose to statically allocate these two pages using PGAlignedBlock
> > structure lazily in verifyBackupPageConsistency() to not waste dynamic
> > memory worth 2*BLCKSZ bytes. I'm attaching a small patch herewith.
> >
> > Thoughts?
>
> IMHO, it's a bit scaring to me to push down the execution stack by
> that large size. I tend to choose the (current) possible memory
> wasting only on startup process than digging stack deeply.

+1



pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Lazy allocation of pages required for verifying FPI consistency
Next
From: Anthonin Bonnefoy
Date:
Subject: Re: Flush SLRU counters in checkpointer process