Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options - Mailing list pgsql-hackers

From sunil s
Subject Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options
Date
Msg-id CAOG6S49=+qSmuw9h3spqUP8g_6MYJ=-4BUyjUTUSK_8JJyz8ZQ@mail.gmail.com
Whole thread Raw
In response to Avoid corrupting DefElem nodes when parsing publication_names and publish options  (sunil s <sunilfeb26@gmail.com>)
Responses Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options
List pgsql-hackers
Here is the reproduction of this issue.

As per the official documentation, creating a publication with the following syntax will corrupt the option list('insert, update, delete')
>  CREATE PUBLICATION mypublication FOR ALL TABLES WITH (publish ='insert, update, delete');

By attaching a debugger to parse_publication_options(), we can verify that the option list is modified after the call to splitIdentifierString().

NOTE: Using double quotes (" "), the functionality works correctly.

Thanks & Regards,
Sunil S

pgsql-hackers by date:

Previous
From: sunil s
Date:
Subject: Avoid corrupting DefElem nodes when parsing publication_names and publish options
Next
From: Jeevan Chalke
Date:
Subject: Add --extra-dependencies and immediate data dumping for pg_dump/pg_upgrade