Request a Demo
Home   >   mailing lists

Re: file_fdw: Support multi-line HEADER option. - Mailing list pgsql-hackers

From Shinya Kato
Subject Re: file_fdw: Support multi-line HEADER option.
Date
Msg-id CAOzEurRY+GAVP12rKjAm3XzzkOnAODV7x_rN-CQ97jpB_PEaSg@mail.gmail.com
Whole thread Raw
In response to Re: file_fdw: Support multi-line HEADER option.  ("songjinzhou" <tsinghualucky912@foxmail.com>)
List pgsql-hackers
Tree view 
On Fri, Jan 9, 2026 at 9:51 PM songjinzhou <tsinghualucky912@foxmail.com> wrote:
> I tested the patch and have no functional questions. I have a small question: Is it necessary to add "(also as a
string,to support file_fdw options)" to the final `ereport` error message in `defCheckCopyHeaderString`? Like in one of
yourcomments below. 

Thank you for reviewing my patch and the comment!

I don’t think we should add “(also as a string, to support file_fdw
options)” to the ereport message because PostgreSQL error messages
typically describe the semantic type rather than the input format.

For instance, REJECT_LIMIT accepts a string in file_fdw but the error
message simply asks for a numeric value.


--
Best regards,
Shinya Kato
NTT OSS Center

pgsql-hackers by date:

Previous
From: "lchch1990@sina.cn"
Date:
Subject: Re: Can we change pg_rewind used without wal_log_hints and data_checksums
Next
From: Chao Li
Date:
Subject: Re: [PATCH] psql: add \dcs to list all constraints