Request a Demo
Home   >   mailing lists

Re: file_fdw: Support multi-line HEADER option. - Mailing list pgsql-hackers

From Shinya Kato
Subject Re: file_fdw: Support multi-line HEADER option.
Date
Msg-id CAOzEurSVZYuoAf57Lio49PrUvom_qSV9XPmhBiOB3GHwcwGOSw@mail.gmail.com
Whole thread Raw
In response to Re: file_fdw: Support multi-line HEADER option.  (Japin Li <japinli@hotmail.com>)
List pgsql-hackers
Tree view 
On Sat, Jan 10, 2026 at 1:14 AM Japin Li <japinli@hotmail.com> wrote:
> A minor nitpick:
>
> +  or a numeric line count for <literal>HEADER</literal>) to enable the desired
> +  behavior.
>
> s/numeric/non-negative integer/
>
> More precise: excludes negative values & clarifies it's an integer.

Thank you for the review! Agreed, and the revised patch is attached.

--
Best regards,
Shinya Kato
NTT OSS Center
Attachment

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: [PATCH] psql: add \dcs to list all constraints
Next
From: Kirill Reshke
Date:
Subject: Re: Fix gistkillitems & add regression test to microvacuum