Obsolete comment in partbounds.c - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Obsolete comment in partbounds.c
Date
Msg-id CAPmGK16Uxr=PatiGyaRwiQVLB7Y-GqbkK3AxRLVYzU0Czv=sEw@mail.gmail.com
Whole thread Raw
Responses Re: Obsolete comment in partbounds.c
List pgsql-hackers
While reviewing the partitionwise-join patch, I noticed $Subject,ie,
this in create_list_bounds():

                /*
                 * Never put a null into the values array, flag instead for
                 * the code further down below where we construct the actual
                 * relcache struct.
                 */
                if (null_index != -1)
                    elog(ERROR, "found null more than once");
                null_index = i;

"the code further down below where we construct the actual relcache
struct" isn't in the same file anymore by refactoring by commit
b52b7dc25.  How about modifying it like the attached?

Best regards,
Etsuro Fujita

Attachment

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] Block level parallel vacuum
Next
From: John Naylor
Date:
Subject: Re: generating catcache control data