Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Fix GetStrictOldestNonRemovableTransactionId() on standby - Mailing list pgsql-committers

From Alexander Korotkov
Subject Re: pgsql: Fix GetStrictOldestNonRemovableTransactionId() on standby
Date
Msg-id CAPpHfdv31iqGdMnW6Zbe=RMmcSRK02iE8iwYD=W=hRXNHRgd9A@mail.gmail.com
Whole thread Raw
In response to pgsql: Fix GetStrictOldestNonRemovableTransactionId() on standby  (Alexander Korotkov <akorotkov@postgresql.org>)
List pgsql-committers
Tree view 
On Fri, Aug 16, 2024 at 12:19 AM Alexander Korotkov
<akorotkov@postgresql.org> wrote:
>
> Fix GetStrictOldestNonRemovableTransactionId() on standby
>
> e85662df44 implemented GetStrictOldestNonRemovableTransactionId() function
> for computation of xid horizon that avoid reporting of false errors.
> However, GetStrictOldestNonRemovableTransactionId() uses
> GetRunningTransactionData() even on standby leading to an assertion failure.
>
> Given that we decided to ignore KnownAssignedXids and standby can't have
> own running xids, we switch to use TransamVariables->nextXid as a xid horizon.
>
> Also, revise the comment regarding ignoring KnownAssignedXids with more
> detailed reasoning provided by Heikki.

I see the buildfarm failures.  I will try to fix them shortly.

------
Regards,
Alexander Korotkov
Supabase

pgsql-committers by date:

Previous
From: Alexander Korotkov
Date:
Subject: pgsql: Fix GetStrictOldestNonRemovableTransactionId() on standby
Next
From: Alexander Korotkov
Date:
Subject: pgsql: Add missing wait_for_catchup() to pg_visibility tap test