Re: collect_corrupt_items_vacuum.patch - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: collect_corrupt_items_vacuum.patch
Date
Msg-id CAPpHfdvN1wsFsPkA8O_DuY3=cOWw0F9nBPi4biyC1+juYQpqdw@mail.gmail.com
Whole thread Raw
In response to Re: collect_corrupt_items_vacuum.patch  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: collect_corrupt_items_vacuum.patch
List pgsql-hackers
On Sun, Jan 14, 2024 at 4:35 AM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> On Sat, Jan 13, 2024 at 7:33 PM Dmitry Koval <d.koval@postgrespro.ru> wrote:
> > Thank you, there is one small point left (in the comment): can you
> > replace "guarantteed to be to be newer" to "guaranteed to be newer",
> > file src/backend/storage/ipc/procarray.c?
>
> Fixed.  Thank you for catching this.

I made the following improvements to the patch.
1. I find a way to implement the path with less changes to the core
code.  The GetRunningTransactionData() function allows to get the
least running xid, all I need is to add database-aware values.
2. I added the TAP test reproducing the original issue.

I'm going to push this if no objections.

------
Regards,
Alexander Korotkov

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: remaining sql/json patches
Next
From: Matthias van de Meent
Date:
Subject: Re: Detoasting optionally to make Explain-Analyze less misleading