On Tue, Jul 29, 2025 at 12:45 PM Oleg Tselebrovskiy
<o.tselebrovskiy@postgrespro.ru> wrote:
> Thanks for your response!
>
> Your patch works with REL_17 & master, but not with REL_16, since there
> is no builtin provider
>
> So if we're going that route, for PostgreSQL 16 and older we could just
> use libc provider instead of builtin for the same effect (see attached)
>
> I've run installcheck-world for both 'builtin' and 'libc', both seem to
> work fine
Great. I'm not sure if we want this to be backpatched. Yet pushed
this to master.
> Dunno what about tests like collate.icu.utf8.sql that require icu
> databases to run. Will those tests be run if we force non-icu locale
> providers in pg_regress? We probaly want them to be run sometimes,
> right? Except this, LGTM
collate.icu.utf8.sql have a protection against running in
inappropriate locale in the top. It's OK to run it with any locale.
If the locale doesn't match then it will be stopped in the beginning
and alternative output collate.icu.utf8_1.out matched.
------
Regards,
Alexander Korotkov
Supabase
