Request a Demo
Home   >   mailing lists

Re: Resetting recovery target parameters in pg_createsubscriber - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: Resetting recovery target parameters in pg_createsubscriber
Date
Msg-id CAPpHfdvaS80t9174rJ5gdpwosmz0_sAK9OYtiKWXKPYymHR_og@mail.gmail.com
Whole thread Raw
In response to Re: Resetting recovery target parameters in pg_createsubscriber  (Alyona Vinter <dlaaren8@gmail.com>)
List pgsql-hackers
Tree view 
Hello, Alyona!

On Mon, Sep 8, 2025 at 8:35 AM Alyona Vinter <dlaaren8@gmail.com> wrote:
>
> Sorry, wrong patches again. Here are the correct ones.

I went though this patches.
1) I've removed the array of parameters.  I see it was proposed by
Michael upthread.  But I think his proposal came from the fact we walk
trough the parameters twice.  But we end up walking trough the
parameter once in setup_recovery(), while reset_recovery_params() just
restores the previous contents.  I think it makes sense to keep the
changes minimal.
2) I reordered patches so that helper function goes first.  I think it
essential to order commit in the way that every commit leaves our tree
in working state.
3) I make pgpreltidy run over  040_pg_createsubscriber.pl.
Any thought?

------
Regards,
Alexander Korotkov
Supabase
Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: --with-llvm on 32-bit platforms?
Next
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Conflict detection for update_deleted in logical replication