Postgres Pro
Downloads
Home   >   mailing lists

Re: GiST kNN search queue (Re: KNN-GiST with recheck) - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: GiST kNN search queue (Re: KNN-GiST with recheck)
Date
Msg-id CAPpHfdvpsHUN=G3cxUPyVAxN2=nhY+x_49BHNnkdr9Q6a4Dt5g@mail.gmail.com
Whole thread Raw
In response to Re: GiST kNN search queue (Re: KNN-GiST with recheck)  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Responses Re: GiST kNN search queue (Re: KNN-GiST with recheck)
List pgsql-hackers
Tree view
Hi!

On Mon, Dec 22, 2014 at 1:07 PM, Heikki Linnakangas <hlinnakangas@vmware.com> wrote:
Ok, thanks for the review! I have committed this, with some cleanup and more comments added.

ISTM that checks in pairingheap_GISTSearchItem_cmp is incorrect. This function should perform inverse comparison. Thus, if item a should be checked first function should return 1. Current behavior doesn't lead to incorrect query answers, but it could be slower than correct version.

------
With best regards,
Alexander Korotkov.
 

Attachment

pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: How about to have relnamespace and relrole?
Next
From: Tim Kane
Date:
Subject: postgres_fdw foreign keys with default sequence