Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-* - Mailing list pgsql-hackers

From Tristan Partin
Subject Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
Date
Msg-id CXDBYZZR3T3Q.3CQUPEYXLP4NL@neon.tech
Whole thread Raw
In response to Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
List pgsql-hackers
Commits look fine to me, but I hate the new target names... Luckily,
I just use plain ninja, so I don't interact with that.

>  +    for name, v in targets_info_byname.items():
>  +        if len(targets_info_byname[name]) > 1:

My only comment is that you could reverse the logic and save yourself an
indentation.

- if len(targets_info_byname[name]) > 1:
+ if len(targets_info_byname[name]) <= 1:
+     continue

But whatever you want.

--
Tristan Partin
Neon (https://neon.tech)



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: [PATCH] pg_convert improvement
Next
From: "Tristan Partin"
Date:
Subject: Re: [RFC] Clang plugin for catching suspicious typedef casting