Re: [PATCH] Check that index can return in get_actual_variable_range() - Mailing list pgsql-hackers

From Maxime Schoemans
Subject Re: [PATCH] Check that index can return in get_actual_variable_range()
Date
Msg-id D65B6A44-429E-4D75-8E96-97A2C9B860EA@enterprisedb.com
Whole thread Raw
In response to Re: [PATCH] Check that index can return in get_actual_variable_range()  (Aleksander Alekseev <aleksander@tigerdata.com>)
List pgsql-hackers
On 18 Sep 2025, at 14:31, Aleksander Alekseev <aleksander@tigerdata.com> wrote:
> Can you think of any test cases we can add to the code base?

The only idea I have would be adding a new index module in src/test/modules that has this particular property and have
atest that will hit get_actual_variable_range(). 
For example, it could be a new access method that is a copy of btree, but whose amcanreturn property is null and that
specificallysets scan->xs_itup to null in amgettuple. 

Without the patch, such a test would fail with 'ERROR: no data returned for index-only scan’, while with the patch it
wouldpass. 

Best,
Maxime Schoemans


pgsql-hackers by date:

Previous
From: Karina Litskevich
Date:
Subject: Re: pg_stat_statements: faster search by queryid
Next
From: Bruce Momjian
Date:
Subject: Re: REPACK and naming