On Tue Sep 9, 2025 at 7:49 PM -03, Rishu Bagga wrote:
> On Tue, Sep 9, 2025 at 3:34 PM Matheus Alcantara
> <matheusssilv97@gmail.com> wrote:
>>
>> On Mon Sep 8, 2025 at 9:08 PM -03, Rishu Bagga wrote:
>> > Hi Joel, Arseniy, Matheus, thanks for taking a look. I’ve attached an
>> > updated patch and rebased on the latest commits that fixes the
>> > correctness issues.
>> >
>> I think that your latest patch miss to include of asyncdesc.c file. I'm
>> getting a compile error:
>>
>> src/backend/access/rmgrdesc/meson.build:4:20: ERROR: File asyncdesc.c does not exist.
>>
>> --
>> Matheus Alcantara
>
> Sorry about that, added the asyncdesc.c file in the attached patch.
>
I'm still seeing some compiler errors.
FAILED: src/backend/postgres_lib.a.p/access_rmgrdesc_asyncdesc.c.o
ccache cc -Isrc/backend/postgres_lib.a.p -Isrc/include -I../src/include -I/opt/homebrew/Cellar/icu4c@77/77.1/include
-I/opt/homebrew/opt/lz4/include-I/opt/homebrew/Cellar/openssl@3/3.5.2/include -I/opt/homebrew/opt/zstd/include
-I/opt/homebrew/opt/openssl@3/include-fdiagnostics-color=always -Wall -Winvalid-pch -O0 -g -isysroot
/Library/Developer/CommandLineTools/SDKs/MacOSX15.2.sdk-fno-strict-aliasing -fwrapv -fexcess-precision=standard
-Wmissing-prototypes-Wpointer-arith -Werror=vla -Werror=unguarded-availability-new -Wendif-labels
-Wmissing-format-attribute-Wcast-function-type -Wformat-security -Wdeclaration-after-statement
-Wmissing-variable-declarations-Wno-unused-command-line-argument -Wno-compound-token-split-by-macro
-Wno-cast-function-type-strict-DBUILDING_DLL -MD -MQ src/backend/postgres_lib.a.p/access_rmgrdesc_asyncdesc.c.o -MF
src/backend/postgres_lib.a.p/access_rmgrdesc_asyncdesc.c.o.d-o
src/backend/postgres_lib.a.p/access_rmgrdesc_asyncdesc.c.o-c ../src/backend/access/rmgrdesc/asyncdesc.c
../src/backend/access/rmgrdesc/asyncdesc.c:17:10: fatal error: 'access/async_xlog.h' file not found
17 | #include "access/async_xlog.h"
| ^~~~~~~~~~~~~~~~~~~~~
1 error generated.
I'm missing something here? I'm using meson+ninja and I remove the build
directory, executed meson setup and then ninja -C build install and I
got this error.
--
Matheus Alcantara