Re: Decouple C++ support in Meson's PGXS from LLVM enablement - Mailing list pgsql-hackers

From Jelte Fennema-Nio
Subject Re: Decouple C++ support in Meson's PGXS from LLVM enablement
Date
Msg-id DFEUTVCYEZRX.38NRHX1TYZPYA@jeltef.nl
Whole thread Raw
In response to Re: Decouple C++ support in Meson's PGXS from LLVM enablement  ("Tristan Partin" <tristan@partin.io>)
Responses Re: Decouple C++ support in Meson's PGXS from LLVM enablement
List pgsql-hackers
On Sat Jan 3, 2026 at 5:49 AM CET, Tristan Partin wrote:
> On Fri Jan 2, 2026 at 10:06 AM CST, Jelte Fennema-Nio wrote:
>> On Fri Nov 7, 2025 at 5:29 PM CET, Tristan Partin wrote:
>>> Great idea. I need to re-spin the patch anyway after a discussion with
>>> Jelte at NYC. I'll be sure to add this as well.
>>
>> I took the liberty of updating the patch to include the g++ fallback and
>> simplify the check a little bit (I seem to remember that that was what
>> we discussed in NYC).
>
> Never saw this email, but here is a little bit cleaner patch. Sorry for
> taking a long time to follow up!

I like a lot better how you default to g++. Here's a version of yours
with a few small "improvements" from my last version:
1. Removal of the unnecessary "and not llvmopt.disabled()" check
2. Replacement of a an additional recenlty added llvm.found() check with have_cpp
3. Default to g++ instead of c++. I know I said I liked the c++ better,
   and I still do, but it seems better to align with autoconf for now
   and then change both of these later if we want to.

Attachment

pgsql-hackers by date:

Previous
From: "Jelte Fennema-Nio"
Date:
Subject: Re: Make copyObject work in C++
Next
From: Peter Eisentraut
Date:
Subject: more POSIX 2008 cleanup: strnlen(), rindex()