Re: Always show correct error message for statement timeouts, fixes random buildfarm failures - Mailing list pgsql-hackers

From Jelte Fennema-Nio
Subject Re: Always show correct error message for statement timeouts, fixes random buildfarm failures
Date
Msg-id DFO9WNI3OW67.6FITRHIIEO8J@jeltef.nl
Whole thread Raw
In response to Re: Always show correct error message for statement timeouts, fixes random buildfarm failures  (Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>)
List pgsql-hackers
On Wed Jan 14, 2026 at 11:42 AM CET, Anthonin Bonnefoy wrote:
> I've encountered a related issue which is fixed by Jelte's patch.

Great that it fixes that too.

> The comment feels a bit misleading.

Updated the comment now (I had copied it verbatim from its original
location, but I agree it didn't describe the new behaviour clearly).

> Is it still possible to have both the statement timeout active and
> fired? You added the change to enable_statement_timeout to avoid
> restarting it when it was already triggered, so I would expect an
> active timeout to not have the indicator flag set. I guess there's the
> possible race where the timeout is triggered between
> get_timeout_active and disable_timeout.

Updated that comment to make it clear that it's indeed there for that rare
race condition.


Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [BUG] [PATCH] Allow physical replication slots to recover from archive after invalidation
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Simplify code building the LR conflict messages