pgsql: Revert addition of third argument to format_type(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Revert addition of third argument to format_type().
Date
Msg-id E1PxoNx-00080e-EX@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Revert addition of third argument to format_type().

Including collation in the behavior of that function promotes a world view
we do not want.  Moreover, it was producing the wrong behavior for pg_dump
anyway: what we want is to dump a COLLATE clause on attributes whose
attcollation is different from the underlying type, and likewise for
domains, and the function cannot do that for us.  Doing it the hard way
in pg_dump is a bit more tedious but produces more correct output.

In passing, fix initdb so that the initial entry in pg_collation is
properly pinned.  It was droppable before :-(

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7564654adf07ec26b83c7effc7f54f7183e04519

Modified Files
--------------
doc/src/sgml/func.sgml               |    6 +--
src/backend/catalog/system_views.sql |    4 --
src/backend/utils/adt/format_type.c  |   25 +++--------
src/bin/initdb/initdb.c              |    2 +
src/bin/pg_dump/common.c             |   15 ++++++-
src/bin/pg_dump/pg_dump.c            |   75 ++++++++++++++++++++++++++++------
src/bin/pg_dump/pg_dump.h            |    2 +
src/include/catalog/catversion.h     |    2 +-
src/include/catalog/pg_proc.h        |    4 +-
9 files changed, 92 insertions(+), 43 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Make error handling of synchronous_standby_names consistent.
Next
From: Bruce Momjian
Date:
Subject: pgsql: Add proper git-external-diff script to src/tools.