pgsql: Handle WAIT_IO_COMPLETION return from WaitForMultipleObjectsEx() - Mailing list pgsql-committers

From Noah Misch
Subject pgsql: Handle WAIT_IO_COMPLETION return from WaitForMultipleObjectsEx()
Date
Msg-id E1XAoMg-0006hj-LZ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Handle WAIT_IO_COMPLETION return from WaitForMultipleObjectsEx().

This return code is possible wherever we pass bAlertable = TRUE; it
arises when Windows caused the current thread to run an "I/O completion
routine" or an "asynchronous procedure call".  PostgreSQL does not
provoke either of those Windows facilities, hence this bug remaining
largely unnoticed, but other local code might do so.  Due to a shortage
of complaints, no back-patch for now.

Per report from Shiv Shivaraju Gowda, this bug can cause
PGSemaphoreLock() to PANIC.  The bug can also cause select() to report
timeout expiration too early, which might confuse pgstat_init() and
CheckRADIUSAuth().

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/de35a9771004b9d521c9d5882db6be4fba20e80e

Modified Files
--------------
src/backend/port/win32/socket.c |    3 +-
src/backend/port/win32_sema.c   |   58 +++++++++++++++++++++++----------------
2 files changed, 37 insertions(+), 24 deletions(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: Move PGAC_LDAP_SAFE to config/programs.m4.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix a performance problem in pg_dump's dump order selection logi