pgsql: Integrate pg_upgrade_support module into backend - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Integrate pg_upgrade_support module into backend
Date
Msg-id E1YiBFU-0002Ih-Qg@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Integrate pg_upgrade_support module into backend

Previously, these functions were created in a schema "binary_upgrade",
which was deleted after pg_upgrade was finished.  Because we don't want
to keep that schema around permanently, move them to pg_catalog but
rename them with a binary_upgrade_... prefix.

The provided functions are only small wrappers around global variables
that were added specifically for pg_upgrade use, so keeping the module
separate does not create any modularity.

The functions still check that they are only called in binary upgrade
mode, so it is not possible to call these during normal operation.

Reviewed-by: Michael Paquier <michael.paquier@gmail.com>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/30982be4e5019684e1772dd9170aaa53f5a8e894

Modified Files
--------------
contrib/Makefile                                |    1 -
contrib/pg_upgrade/dump.c                       |    2 +-
contrib/pg_upgrade/function.c                   |  113 --------------
contrib/pg_upgrade/pg_upgrade.c                 |   27 ----
contrib/pg_upgrade/pg_upgrade.h                 |    2 -
contrib/pg_upgrade/test.sh                      |    1 -
contrib/pg_upgrade_support/Makefile             |   16 --
contrib/pg_upgrade_support/pg_upgrade_support.c |  190 -----------------------
doc/src/sgml/pgupgrade.sgml                     |    5 +-
src/backend/catalog/heap.c                      |    2 +-
src/backend/catalog/index.c                     |    2 +-
src/backend/catalog/pg_enum.c                   |    2 +-
src/backend/catalog/pg_type.c                   |    2 +-
src/backend/catalog/toasting.c                  |    2 +-
src/backend/commands/typecmds.c                 |    2 +-
src/backend/commands/user.c                     |    2 +-
src/backend/utils/adt/Makefile                  |    3 +-
src/backend/utils/adt/pg_upgrade_support.c      |  183 ++++++++++++++++++++++
src/bin/pg_dump/pg_dump.c                       |   18 +--
src/bin/pg_dump/pg_dumpall.c                    |    2 +-
src/include/catalog/pg_proc.h                   |   20 +++
21 files changed, 225 insertions(+), 372 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Move pg_upgrade from contrib/ to src/bin/
Next
From: Fujii Masao
Date:
Subject: Re: pgsql: Mark the second argument of pg_log as the translatable string in