pgsql: Build HashState's hashkeys expression with the correct parent. - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Build HashState's hashkeys expression with the correct parent.
Date
Msg-id E1gKRd5-0000th-3s@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Build HashState's hashkeys expression with the correct parent.

Previously the expressions were built with the HashJoinState as a
parent. That's incorrect.

Currently this does not appear to be harmful, but for the upcoming
'slot abstraction' work this proves to be problematic, as the
underlying slot types can differ between Hash and HashJoin.  It's
possible that this already causes a problem, but I've not been able to
come up with a scenario.  Therefore don't backpatch at this point.

Author: Andres Freund
Discussion: https://postgr.es/m/20180220224318.gw4oe5jadhpmcdnm@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5f32b29c18195299e90c1fb6c8945e9a46d772d2

Modified Files
--------------
src/backend/executor/nodeHashjoin.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Use installcheck-parallel in pg_upgrade's testsuite.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: pg_upgrade: Allow use of file cloning