pgsql: Remove dead foreign key optimization code - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Remove dead foreign key optimization code
Date
Msg-id E1gLV4b-00089D-L2@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Remove dead foreign key optimization code
List pgsql-committers
Remove dead foreign key optimization code

The ri_KeysEqual() calls in the foreign-key trigger functions to
optimize away some updates are useless because since
adfeef55cbcc5dc72a772777f88c1be05a70dfee those triggers are not enqueued
at all.  (It's also not useful to keep these checks as some kind of
backstop, since it's also semantically correct to just run the full
check even with equal keys.)

Reviewed-by: Daniel Gustafsson <daniel@yesql.se>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/34479d9a36a280afe1387146871d4c1528cf2cbf

Modified Files
--------------
src/backend/utils/adt/ri_triggers.c | 51 -------------------------------------
1 file changed, 51 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: Re: pgsql: Remove ineffective check against dropped columns from slot_getat
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Remove ineffective check against dropped columns fromslot_getat