pgsql: Fix tablespace handling for partitioned tables - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Fix tablespace handling for partitioned tables
Date
Msg-id E1gYxsp-0002m8-5f@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix tablespace handling for partitioned tables

When partitioned tables were introduced, we failed to realize that by
copying the tablespace handling for other relation kinds with no
physical storage we were causing the secondary effect that their
partitions would not automatically inherit the tablespace setting.  This
is surprising and unhelpful, so change it to adopt the behavior
introduced in pg11 (commit 33e6c34c3267) for partitioned indexes: the
parent relation remembers the tablespace specification, which is then
used for any new partitions that don't declare one.

Because this commit changes behavior of the TABLESPACE clause for
partitioned tables (it's no longer a no-op), it is not backpatched.

Author: David Rowley, Álvaro Herrera
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/CAKJS1f9SxVzqDrGD1teosFd6jBMM0UEaa14_8mRvcWE19Tu0hA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ca4103025dfe26eaaf6a500dec9170fbb176eebc

Modified Files
--------------
doc/src/sgml/ref/create_table.sgml        |   6 +-
src/backend/catalog/heap.c                |   6 +-
src/backend/commands/tablecmds.c          | 152 +++++++++++++++++++-----------
src/include/catalog/pg_class.h            |  13 +++
src/test/regress/input/tablespace.source  |  12 +++
src/test/regress/output/tablespace.source |  19 ++++
6 files changed, 147 insertions(+), 61 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Clarify runtime pruning in EXPLAIN
Next
From: Tom Lane
Date:
Subject: pgsql: Drop support for getting signal descriptions fromsys_siglist[].