pgsql: Improve pruning of a default partition - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Improve pruning of a default partition
Date
Msg-id E1huIKq-00050o-QX@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Improve pruning of a default partition
Re: pgsql: Improve pruning of a default partition
List pgsql-committers
Improve pruning of a default partition

When querying a partitioned table containing a default partition, we
were wrongly deciding to include it in the scan too early in the
process, failing to exclude it in some cases.  If we reinterpret the
PruneStepResult.scan_default flag slightly, we can do a better job at
detecting that it can be excluded.  The change is that we avoid setting
the flag for that pruning step unless the step absolutely requires the
default partition to be scanned (in contrast with the previous
arrangement, which was to set it unless the step was able to prune it).
So get_matching_partitions() must explicitly check the partition that
each returned bound value corresponds to in order to determine whether
the default one needs to be included, rather than relying on the flag
from the final step result.

Author: Yuzuko Hosoya <hosoya.yuzuko@lab.ntt.co.jp>
Reviewed-by: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Discussion: https://postgr.es/m/00e601d4ca86$932b8bc0$b982a340$@lab.ntt.co.jp

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/86544071484a48c753e719e0c7c9cf816a59a65e

Modified Files
--------------
src/backend/partitioning/partprune.c          | 219 ++++++++++++--------------
src/include/partitioning/partbounds.h         |   1 -
src/test/regress/expected/partition_prune.out |  20 ++-
src/test/regress/sql/partition_prune.sql      |   1 +
4 files changed, 111 insertions(+), 130 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Make relnote item wording consistent
Next
From: Tom Lane
Date:
Subject: pgsql: Avoid picking already-bound TCP ports in kerberos and ldaptest