Postgres Pro
Downloads
Home   >   mailing lists

pgAdmin 4 commit: Fixed following SonarQube issues: - Mailing list pgadmin-hackers

From Akshay Joshi
Subject pgAdmin 4 commit: Fixed following SonarQube issues:
Date
Msg-id E1jojSi-0005gO-7q@gothos.postgresql.org
Whole thread Raw
List pgadmin-hackers
Tree view 
Fixed following SonarQube issues:
1. Boolean checks should not be inverted.
2. The comma operator should not be used.
3. Arguments to built-in functions should match documented types.
4. Redundant pairs of parentheses should be removed.
5. A conditionally executed single line should be denoted by indentation,
6. A while loop should be used instead of a 'for' loop.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=707ff450b5ddaf69b8d4052c579aaa2807e99c64
Author: Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>

Modified Files
--------------
.../server_groups/servers/databases/schemas/types/static/js/type.js | 4 ++--
web/pgadmin/static/js/codemirror/addon/fold/pgadmin-sqlfoldcode.js  | 5 +++--
web/pgadmin/static/js/pgadmin.js                                    | 2 +-
web/pgadmin/static/js/sqleditor_utils.js                            | 3 ++-
web/pgadmin/tools/backup/static/js/backup.js                        | 2 +-
web/pgadmin/tools/debugger/static/js/direct.js                      | 3 ++-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js                  | 6 ++++--
web/pgadmin/tools/user_management/static/js/user_management.js      | 4 ++--
8 files changed, 17 insertions(+), 12 deletions(-)

pgadmin-hackers by date:

Previous
From: Nikhil Mohite
Date:
Subject: Support schema level restrictions and edit connection properties whenalready connected.
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checksshould not be inverted, Comma operator should not be used)