pgsql: Move catalog index declarations - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Move catalog index declarations
Date
Msg-id E1kbMSG-0002F1-Sg@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Move catalog index declarations

Move the system catalog index declarations from catalog/indexing.h to
the respective parent tables' catalog/pg_*.h files.  The original
reason for having it split was that the old genbki system produced the
output in the order of the catalog files it read, so all the indexing
stuff needed to come separately.  But this is no longer the case, and
keeping it together makes more sense.

Reviewed-by: John Naylor <john.naylor@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/flat/c7cc82d6-f976-75d6-2e3e-b03d2cab26bb@2ndquadrant.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bdc4edbea6fc847f806e1e7118d730e159512bfc

Modified Files
--------------
contrib/dblink/dblink.c                       |   1 -
contrib/sepgsql/database.c                    |   1 -
contrib/sepgsql/label.c                       |   1 -
contrib/sepgsql/proc.c                        |   1 -
contrib/sepgsql/relation.c                    |   1 -
contrib/sepgsql/schema.c                      |   1 -
doc/src/sgml/bki.sgml                         |   5 +-
src/backend/catalog/Makefile                  |   4 +-
src/backend/catalog/catalog.c                 |   3 +-
src/backend/catalog/objectaddress.c           |   1 -
src/backend/commands/aggregatecmds.c          |   1 -
src/backend/commands/tablecmds.c              |   1 -
src/backend/partitioning/partdesc.c           |   1 -
src/backend/replication/logical/message.c     |   1 -
src/backend/rewrite/rewriteDefine.c           |   1 -
src/backend/utils/adt/enum.c                  |   1 -
src/backend/utils/adt/ruleutils.c             |   1 -
src/backend/utils/cache/evtcache.c            |   1 -
src/backend/utils/cache/relfilenodemap.c      |   1 -
src/backend/utils/cache/syscache.c            |   3 +-
src/backend/utils/cache/ts_cache.c            |   1 -
src/backend/utils/cache/typcache.c            |   1 -
src/backend/utils/init/postinit.c             |   1 -
src/include/catalog/duplicate_oids            |   2 +-
src/include/catalog/genbki.h                  |  17 ++
src/include/catalog/indexing.h                | 323 --------------------------
src/include/catalog/pg_aggregate.h            |   3 +
src/include/catalog/pg_am.h                   |   5 +
src/include/catalog/pg_amop.h                 |   7 +
src/include/catalog/pg_amproc.h               |   5 +
src/include/catalog/pg_attrdef.h              |   5 +
src/include/catalog/pg_attribute.h            |   5 +
src/include/catalog/pg_auth_members.h         |   5 +
src/include/catalog/pg_authid.h               |   5 +
src/include/catalog/pg_cast.h                 |   5 +
src/include/catalog/pg_class.h                |   7 +
src/include/catalog/pg_collation.h            |   5 +
src/include/catalog/pg_constraint.h           |  11 +
src/include/catalog/pg_conversion.h           |   7 +
src/include/catalog/pg_database.h             |   5 +
src/include/catalog/pg_db_role_setting.h      |   3 +
src/include/catalog/pg_default_acl.h          |   5 +
src/include/catalog/pg_depend.h               |   5 +
src/include/catalog/pg_description.h          |   3 +
src/include/catalog/pg_enum.h                 |   7 +
src/include/catalog/pg_event_trigger.h        |   5 +
src/include/catalog/pg_extension.h            |   5 +
src/include/catalog/pg_foreign_data_wrapper.h |   5 +
src/include/catalog/pg_foreign_server.h       |   5 +
src/include/catalog/pg_foreign_table.h        |   3 +
src/include/catalog/pg_index.h                |   5 +
src/include/catalog/pg_inherits.h             |   5 +
src/include/catalog/pg_init_privs.h           |   3 +
src/include/catalog/pg_language.h             |   5 +
src/include/catalog/pg_largeobject.h          |   3 +
src/include/catalog/pg_largeobject_metadata.h |   3 +
src/include/catalog/pg_namespace.h            |   5 +
src/include/catalog/pg_opclass.h              |   5 +
src/include/catalog/pg_operator.h             |   5 +
src/include/catalog/pg_opfamily.h             |   5 +
src/include/catalog/pg_partitioned_table.h    |   3 +
src/include/catalog/pg_policy.h               |   5 +
src/include/catalog/pg_proc.h                 |   5 +
src/include/catalog/pg_publication.h          |   5 +
src/include/catalog/pg_publication_rel.h      |   5 +
src/include/catalog/pg_range.h                |   3 +
src/include/catalog/pg_replication_origin.h   |   5 +
src/include/catalog/pg_rewrite.h              |   5 +
src/include/catalog/pg_seclabel.h             |   3 +
src/include/catalog/pg_sequence.h             |   3 +
src/include/catalog/pg_shdepend.h             |   5 +
src/include/catalog/pg_shdescription.h        |   3 +
src/include/catalog/pg_shseclabel.h           |   3 +
src/include/catalog/pg_statistic.h            |   3 +
src/include/catalog/pg_statistic_ext.h        |   7 +
src/include/catalog/pg_statistic_ext_data.h   |   3 +
src/include/catalog/pg_subscription.h         |   5 +
src/include/catalog/pg_subscription_rel.h     |   3 +
src/include/catalog/pg_tablespace.h           |   5 +
src/include/catalog/pg_transform.h            |   5 +
src/include/catalog/pg_trigger.h              |   7 +
src/include/catalog/pg_ts_config.h            |   5 +
src/include/catalog/pg_ts_config_map.h        |   3 +
src/include/catalog/pg_ts_dict.h              |   5 +
src/include/catalog/pg_ts_parser.h            |   5 +
src/include/catalog/pg_ts_template.h          |   5 +
src/include/catalog/pg_type.h                 |   5 +
src/include/catalog/pg_user_mapping.h         |   5 +
src/include/catalog/renumber_oids.pl          |  15 +-
src/include/catalog/unused_oids               |   2 +-
src/tools/msvc/Solution.pm                    |   1 -
91 files changed, 318 insertions(+), 370 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Plug memory leak in index_get_partition
Next
From: Tom Lane
Date:
Subject: pgsql: Fix ecpg's mishandling of B'...' and X'...' literals.