pgsql: nbtree: Demote incomplete split "can't happen" error. - Mailing list pgsql-committers

From Peter Geoghegan
Subject pgsql: nbtree: Demote incomplete split "can't happen" error.
Date
Msg-id E1keO6A-0005sQ-6K@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
nbtree: Demote incomplete split "can't happen" error.

Only a basic logic bug in a _bt_insertonpg() caller could lead to a
violation of this invariant (index corruption won't do it).  A "can't
happen" error seems inappropriate (it is arbitrary at best).

Demote the error to a simple assertion.  This matches similar nearby
sanity checks.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/46cf3c72c36fef8c623b4b97d8720321d8ad7507

Modified Files
--------------
src/backend/access/nbtree/nbtinsert.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Suppress "warning: variable 'collcollate' set but not used".
Next
From: Tom Lane
Date:
Subject: pgsql: Fix fuzzy thinking about amcanmulticol versus amcaninclude.