pgsql: Fix bogus logic for reporting which hash partition conflicts. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix bogus logic for reporting which hash partition conflicts.
Date
Msg-id E1lyIZN-0001T1-Ns@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix bogus logic for reporting which hash partition conflicts.

Commit efbfb6424 added logic for reporting exactly which existing
partition conflicts when complaining that a new hash partition's
modulus isn't compatible with the existing ones.  However, it
misunderstood the partitioning data structure, and would select
the wrong partition in some cases, or crash outright due to fetching
a bogus table OID in other cases.

Per bug #17076 from Alexander Lakhin.  Fix by Amit Langote;
some further work on the code comments by me.

Discussion: https://postgr.es/m/17076-89a16ae835d329b9@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dd2364ced98553e0217bfe8f621cd4b0970db74a

Modified Files
--------------
src/backend/partitioning/partbounds.c      | 26 ++++++++++++++++++--------
src/test/regress/expected/create_table.out | 10 ++++++++--
src/test/regress/sql/create_table.sql      |  3 +++
3 files changed, 29 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Add a build-time check that libpq doesn't call exit() or abort()
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Add PQsendFlushRequest to libpq