pgsql: Disable test for postgres -C on Msys - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Disable test for postgres -C on Msys
Date
Msg-id E1mR1WB-0007Oj-Sh@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Disable test for postgres -C on Msys

The output generated on Msys is incorrect because of the different way
IPC::Run processes outputs with native Perl (converts natively \r\n to
\n) and Msys perl (\r\n kept as-is), causing this test to fail.

For now, just disable the test to bring the buildfarm to a green state.
I think that the correct long-term solution would be to tweak all the
routines command_checks_* in PostgresNode.pm to handle this output like
psql does when using Msys, by discarding \r automatically before
comparing it.

Per report from jacana and fairywren.  Thanks to Tom Lane for the ping.

Discussion: https://postgr.es/m/1252480.1631829409@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5adb06732d7fac8171609392ea83f18bc8f285f4

Modified Files
--------------
src/bin/pg_checksums/t/002_actions.pl | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Support "postgres -C" with runtime-computed GUCs
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Support "postgres -C" with runtime-computed GUCs