pgsql: Simplify the inner loop of numeric division in div_var(). - Mailing list pgsql-committers

From Dean Rasheed
Subject pgsql: Simplify the inner loop of numeric division in div_var().
Date
Msg-id E1nOH0p-00086N-JS@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Simplify the inner loop of numeric division in div_var().

In the standard numeric division algorithm, the inner loop multiplies
the divisor by the next quotient digit and subtracts that from the
working dividend. As suggested by the original code comment, the
separate "carry" and "borrow" variables (from the multiplication and
subtraction steps respectively) can be folded together into a single
variable. Doing so significantly improves performance, as well as
simplifying the code.

Dean Rasheed, reviewed by Tom Lane.

Discussion: https://postgr.es/m/CAEZATCVwsBi-ND-t82Cuuh1=8ee6jdOpzsmGN+CUZB6yjLg9jw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d996d648f333b04ae3da3c5853120f6f37601fb2

Modified Files
--------------
src/backend/utils/adt/numeric.c | 36 +++++++++++++++---------------------
1 file changed, 15 insertions(+), 21 deletions(-)


pgsql-committers by date:

Previous
From: Dean Rasheed
Date:
Subject: pgsql: Apply auto-vectorization to the inner loop of div_var_fast().
Next
From: Dean Rasheed
Date:
Subject: pgsql: Optimise numeric division for one and two base-NBASE digit divis