pgsql: Fix COPY FROM when database encoding is SQL_ASCII. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Fix COPY FROM when database encoding is SQL_ASCII.
Date
Msg-id E1nvQ9H-001lLF-UJ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix COPY FROM when database encoding is SQL_ASCII.

In the codepath when no encoding conversion is required, the check for
incomplete character at the end of input incorrectly used server
encoding's max character length, instead of the client's. Usually the
server and client encodings are the same when we're not performing
encoding conversion, but SQL_ASCII is an exception.

In the passing, also fix some outdated comments that still talked about
the old COPY protocol. It was removed in v14.

Per bug #17501 from Vitaly Voronov. Backpatch to v14 where this was
introduced.

Discussion: https://www.postgresql.org/message-id/17501-128b1dd039362ae6@postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f82595ac903e4e4062d909e73693dd809c6845c0

Modified Files
--------------
src/backend/commands/copyfromparse.c | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Doc: fix missing/bogus documentation of range_intersect_agg().
Next
From: Michael Paquier
Date:
Subject: pgsql: doc: Reword description of roles able to view track_activities's