pgsql: Harmonize heapam and tableam parameter names. - Mailing list pgsql-committers

From Peter Geoghegan
Subject pgsql: Harmonize heapam and tableam parameter names.
Date
Msg-id E1oaQTi-0017GK-9n@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Harmonize heapam and tableam parameter names.

Make sure that function declarations use names that exactly match the
corresponding names from function definitions.  Having parameter names
that are reliably consistent in this way will make it easier to reason
about groups of related C functions from the same translation unit as a
module.  It will also make certain refactoring tasks easier.

Like other recent commits that cleaned up function parameter names, this
commit was written with help from clang-tidy.  Later commits will do the
same for other parts of the codebase.

Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4bac9600f09a9b9ba7daa3ba69495a877f51e6c3

Modified Files
--------------
src/backend/access/common/heaptuple.c       | 14 ++++----
src/backend/access/heap/heapam.c            |  2 +-
src/backend/access/heap/heapam_visibility.c | 16 ++++-----
src/backend/access/heap/visibilitymap.c     | 56 ++++++++++++++---------------
src/backend/access/table/tableam.c          | 11 +++---
src/backend/access/transam/multixact.c      |  6 ++--
src/include/access/heapam.h                 | 26 +++++++-------
src/include/access/heapam_xlog.h            |  4 +--
src/include/access/htup_details.h           |  2 +-
src/include/access/multixact.h              |  7 ++--
src/include/access/rewriteheap.h            | 12 +++----
src/include/access/tableam.h                |  8 ++---
src/include/commands/cluster.h              |  2 +-
src/include/replication/snapbuild.h         | 13 +++----
14 files changed, 90 insertions(+), 89 deletions(-)


pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Consistently use named parameters in regex code consistently.
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Fix createdb tests for C locale