pgsql: pg_dump: Refactor code that constructs ALTER ... OWNER TO comman - Mailing list pgsql-committers

pg_dump: Refactor code that constructs ALTER ... OWNER TO commands

Avoid having to list all the possible object types twice.  Instead,
only _getObjectDescription() needs to know about specific object
types.  It communicates back to _printTocEntry() whether an owner is
to be set.

In passing, remove the logic to use ALTER TABLE to set the owner of
views and sequences.  This is no longer necessary.  Furthermore, if
pg_dump doesn't recognize the object type, this is now a fatal error,
not a warning.

Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/0a00f923-599a-381b-923f-0d802a727715@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3655b46aa0b8156aced0b9ee3d10875632f84407

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 130 +++++++++++++----------------------
1 file changed, 47 insertions(+), 83 deletions(-)