pgsql: pg_dump: Add support for zstd compression - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: pg_dump: Add support for zstd compression
Date
Msg-id E1pk8zo-001XX9-M3@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_dump: Add support for zstd compression

Allow pg_dump to use the zstd compression, in addition to gzip/lz4. Bulk
of the new compression method is implemented in compress_zstd.{c,h},
covering the pg_dump compression APIs. The rest of the patch adds test
and makes various places aware of the new compression method.

The zstd library (which this patch relies on) supports multithreaded
compression since version 1.5. We however disallow that feature for now,
as it might interfere with parallel backups on platforms that rely on
threads (e.g. Windows). This can be improved / relaxed in the future.

This also fixes a minor issue in InitDiscoverCompressFileHandle(), which
was not updated to check if the file already has the .lz4 extension.

Adding zstd compression was originally proposed in 2020 (see the second
thread), but then was reworked to use the new compression API introduced
in e9960732a9. I've considered both threads when compiling the list of
reviewers.

Author: Justin Pryzby
Reviewed-by: Tomas Vondra, Jacob Champion, Andreas Karlsson
Discussion: https://postgr.es/m/20230224191840.GD1653@telsasoft.com
Discussion: https://postgr.es/m/20201221194924.GI30237@telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/84adc8e20f54e93a003cd316fa1eb9b03e393288

Modified Files
--------------
doc/src/sgml/ref/pg_dump.sgml         |  13 +-
src/bin/pg_dump/Makefile              |   2 +
src/bin/pg_dump/compress_io.c         |  72 +++--
src/bin/pg_dump/compress_zstd.c       | 537 ++++++++++++++++++++++++++++++++++
src/bin/pg_dump/compress_zstd.h       |  25 ++
src/bin/pg_dump/meson.build           |   4 +-
src/bin/pg_dump/pg_backup_archiver.c  |   6 +-
src/bin/pg_dump/pg_backup_directory.c |   2 +
src/bin/pg_dump/pg_dump.c             |  25 +-
src/bin/pg_dump/t/002_pg_dump.pl      |  79 ++++-
src/tools/pginclude/cpluspluscheck    |   1 +
src/tools/pgindent/typedefs.list      |   1 +
12 files changed, 713 insertions(+), 54 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: bufmgr: Add Pin/UnpinLocalBuffer()
Next
From: Tom Lane
Date:
Subject: pgsql: Acquire locks on views in AcquirePlannerLocks, too.