pgsql: Fix possible NULL pointer dereference in GetNamedDSMSegment(). - Mailing list pgsql-committers

From Nathan Bossart
Subject pgsql: Fix possible NULL pointer dereference in GetNamedDSMSegment().
Date
Msg-id E1rS6my-002fhV-62@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix possible NULL pointer dereference in GetNamedDSMSegment().

GetNamedDSMSegment() doesn't check whether dsm_attach() returns
NULL, which creates the possibility of a NULL pointer dereference
soon after.  To fix, emit an ERROR if dsm_attach() returns NULL.
This shouldn't happen, but it would be nice to avoid a segfault if
it does.  In passing, tidy up the surrounding code.

Reported-by: Tom Lane
Reviewed-by: Michael Paquier, Bharath Rupireddy
Discussion: https://postgr.es/m/3348869.1705854106%40sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4372adfa24f2f5ddc587317d634b5389bd764106

Modified Files
--------------
src/backend/storage/ipc/dsm_registry.c | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix ERROR message in injection_point.c
Next
From: Michael Paquier
Date:
Subject: pgsql: ci: Enable injection points in builds