pgsql: meson: macos: Avoid warnings on Sonoma - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: meson: macos: Avoid warnings on Sonoma
Date
Msg-id E1rkKZ9-003Zz7-Ji@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
meson: macos: Avoid warnings on Sonoma

Starting with the Sonoma toolchain macos' linker emits warnings when the same
library is linked to twice. That's ill considered, as the same library can be
used by multiple subsidiary libraries. Luckily there's a flag to suppress that
warning.

On Ventura meson's default of -Wl,-undefined,dynamic_lookup caused warnings,
which we suppressed with -Wl,-undefined,error. Unfortunately that causes a
warning on Sonoma, which is absurd, as it's documented linker default. To
avoid that warning, only add -Wl,-undefined,error if it does not trigger
warnings. Luckily dynamic_lookup doesn't trigger a warning on Sonoma anymore.

Discussion: https://postgr.es/m/20231201040515.p5bshhhtfru7d3da@awork3.anarazel.de
Backpatch: 16-, where the meson build was added

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a3da95deee38ee067b0bead639c830eacbe894d5

Modified Files
--------------
meson.build | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix incorrect format placeholders
Next
From: Andres Freund
Date:
Subject: pgsql: meson: macos: Avoid warnings on Sonoma