pgsql: Speedup WindowAgg code by moving uncommon code out-of-line - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Speedup WindowAgg code by moving uncommon code out-of-line
Date
Msg-id E1sm3fZ-000C2i-2p@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Speedup WindowAgg code by moving uncommon code out-of-line

The code to calculate the frame offsets is only performed once per scan.
Moving this code out of line gives a small (around 4-5%) speedup when testing
with some CPUs.  Other tested CPUs are indifferent to the change.

Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Reviewed-by: Tatsuo Ishii <ishii@postgresql.org>
Discussion: https://postgr.es/m/CAApHDvqPgFtwme2Zyf75BpMLwYr2mnUstDyPiP%3DEpudYuQTPPQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/19b861f880166fbdb67d268955e590881376f876

Modified Files
--------------
src/backend/executor/nodeWindowAgg.c | 140 +++++++++++++++++++----------------
1 file changed, 78 insertions(+), 62 deletions(-)


pgsql-committers by date:

Previous
From: Jeff Davis
Date:
Subject: pgsql: Remove lc_collate_is_c().
Next
From: David Rowley
Date:
Subject: pgsql: Optimize WindowAgg's use of tuplestores