pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing - Mailing list pgsql-committers

From Amit Langote
Subject pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing
Date
Msg-id E1smPJZ-000LNf-7P@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
SQL/JSON: Fix JSON_TABLE() column deparsing

The deparsing code in get_json_expr_options() unnecessarily emitted
the default column-specific ON ERROR / EMPTY behavior when the
top-level ON ERROR behavior in JSON_TABLE was set to ERROR. Fix that
by not overriding the column-specific default, determined based on
the column's JsonExprOp in get_json_table_columns(), with
JSON_BEHAVIOR_ERROR when that is the top-level ON ERROR behavior.

Note that this only removes redundancy; the current deparsing output
is not incorrect, just redundant.

Reviewed-by: Jian He <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxEo4sUjKCYtda0_qt9tazqqKPmF1cqhW9KBOUeJFqQd2g@mail.gmail.com
Backpatch-through: 17

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c88ce386c4d7bfeb437ff31ec7c23c392c862e77

Modified Files
--------------
src/backend/utils/adt/ruleutils.c               |  8 ++++----
src/test/regress/expected/sqljson_jsontable.out | 18 ++++++++++++++++++
src/test/regress/sql/sqljson_jsontable.sql      |  5 +++++
3 files changed, 27 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: doc PG 17 relnotes: remove tab complete for MERGE/SPLIT partit.
Next
From: Amit Langote
Date:
Subject: pgsql: SQL/JSON: Avoid initializing unnecessary ON ERROR / ON EMPTY ste